Adds Generic OIDC accounts #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
IsaacCalligeros95
force-pushed
the
isaac/generic-oidc-accounts
branch
from
11ac956 to
2784fab
Compare
IsaacCalligeros95
force-pushed
the
isaac/generic-oidc-accounts
branch
from
2784fab to
d3e8e8f
Compare
benPearce1
reviewed
Dec 3, 2024
Comment on lines
17
to
21
| [Writeable] | ||
| public string[] HealthCheckSubjectKeys { get; set; } | ||
|
|
||
| [Writeable] | ||
| public string[] AccountTestSubjectKeys { get; set; } |
There was a problem hiding this comment.
This is going to be confusing for users, I know we excluded it on the UI but this allows the user to set something that has no discernable effect
benPearce1
approved these changes
Dec 3, 2024
To prevent the resource mismatch errors I'd have up remove these fields from the resource in Server. I can do that but we'll end up with the mismatch being between the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for generic Oidc accounts to the client for #project-generic-oidc